Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell completion fix no file comp directive #1363

Merged
merged 1 commit into from May 3, 2021
Merged

Conversation

@Luap99
Copy link
Contributor

@Luap99 Luap99 commented Mar 5, 2021

Make sure to filter the returned completions before we check if there are valid completions left.

Fixes #1362

Make sure to filter the returned completions before we check if
there are valid completions left.

Fixes spf13#1362

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
@Luap99
Copy link
Contributor Author

@Luap99 Luap99 commented Mar 5, 2021

@umarcor The MINGW64 workflow is failing with a missing go module. Can you take a look?

/cc @jpmcb

Copy link
Contributor

@marckhouzam marckhouzam left a comment

Thanks for the quick fix @Luap99, works great.

@umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 12, 2021

@Luap99, see #1366.

jpmcb
jpmcb approved these changes May 3, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

LGTM - thanks for the patience on this one!

@jpmcb jpmcb merged commit 7223a99 into spf13:master May 3, 2021
7 of 8 checks passed
@Luap99 Luap99 deleted the fix-1362 branch May 3, 2021
@jpmcb jpmcb mentioned this pull request May 3, 2021
@renovate renovate bot mentioned this pull request Jul 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants