-
Notifications
You must be signed in to change notification settings - Fork 11
work in progress, add search keyword update action #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
3ad2898 to
f47d076
Compare
|
@PhilippSpo happy for me to merge this? Tests go green :) |
|
@sebbulon one question: search keywords can be defined with different tokenizers. Do you consider this in the implementation? Or how does that work with the csv import? |
|
@emmenko indeed .. custom tokenisers are not supported right now by this PR |
|
So how is this going to work? |
|
@sebbulon There are no tests for updating existing search keywords, right? |
|
@emmenko I didn't really change anything there as you can see. The CSV import already supported search keyword export to some extend, I added Search Keyword import - there was only one little change necessary. I guess we need to make this clear in the documentation + have another change request to support the different tokenisers. |
|
@PhilippSpo right tests are not complete |
|
@emmenko to answer your question - the ususal case how people use this is to tokenise the search keywords already. If they are provided separated by semicolon (or whatever the secondary delimiter is), it will be imported into separate text elements, each of them being a different token. So they technically don't need a whitespace tokeniser. I will add this to the readme |
89a39ef to
5fa18d9
Compare
…-node-product-csv-sync into add_search_keyword_delta
To check whether the existing search keywords sayed untouched by the import
…sync into add_search_keyword_delta # Conflicts: # README.md # package.json
This reverts commit 47584b9.
apparently only sku is not enough - the variantId also needs to be provided (which might be problematic for customers)
|
OK we can merge this in my opinion. |
work in progress, add search keyword update action
WIP, added search keyword action