-
Notifications
You must be signed in to change notification settings - Fork 11
feat(export): add variant and price filters #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do those 2 filter and the queryString options interfere with each other. Can they all be chosen independent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 filters are not added to the query, but are applied to the result. So yes they can be chosen independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Makes sense ;)
if the price filter removes all prices from the variant, then the whole variant should be removed since the variant is not relevant regarding the filter
|
@PhilippSpo btw: we should prevent using the search endpoint for exports. |
|
Sound reasonable for me to remove the search option. |
|
Why not using search endpoint for exports? Is it some common rule or just currently bad practice? |
|
@butenkor I just asked @agourlay on this and he gave me a great response:
Thanks for clarifying @agourlay 👍 |
|
Thanks for info. |
…dpoint for exporting
|
OK I fixed the tests locally. We are experiencing some coveralls issues here... |
…ilters feat(export): add variant and price filters
@emmenko @hajoeichler @mmoelli
This is not the most beautiful solution, but it works for the moment.
We can now filter variants by attributes and we can filter the variants prices.
If a variant has no prices left, after the price filter was applied to it, it gets removed from the export. This gives use the possibility to export for certain countries only.
What do you think about this approach?