builder: avoid unchanged page cache checks if we have legacy pages #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before attempting to cleanup any detected legacy pages from a target Confluence instance, the builder will check to see if any unchanged documents exist (pages that did not trigger an update and we not removed from the internal legacy list), and remove them from the legacy pages list if our cache detects it was already published. However, this logic assumes we have populated a legacy pages list ahead of time, which may not have happened if we are not configured for any cleaning. This commit adjusts the unchanged pages check to only occur if we have populated a legacy pages list to check on. Signed-off-by: James Knight <james.d.knight@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before attempting to cleanup any detected legacy pages from a target Confluence instance, the builder will check to see if any unchanged documents exist (pages that did not trigger an update and we not removed from the internal legacy list), and remove them from the legacy pages list if our cache detects it was already published. However, this logic assumes we have populated a legacy pages list ahead of time, which may not have happened if we are not configured for any cleaning.
This commit adjusts the unchanged pages check to only occur if we have populated a legacy pages list to check on.