Fix software version #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked the BIDSification script and everything seems fine. |
jcohenadad
approved these changes
Nov 10, 2021
|
@alexfoias can you pls update the branch |
|
@jcohenadad I updated the branch. |
|
@alexfoias can you please update this PR after #112 |
jcohenadad
approved these changes
Jan 20, 2022
|
at some point it would be great to make the validator more flexible because we keep merging with the validator failing... |
|
We had an error because of the /scripts folder. Changed it to be compliant as per documentation https://bids-specification.readthedocs.io/en/stable/03-modality-agnostic-files.html#code |
|
@jcohenadad the 1bb0a32 seemed to have fixed the issue. We can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was reported by external collaborator on Oct 8, 2021
to merge after #109