feat(marketplace): initial marketplace directory with helm charts #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
approved these changes
Jun 21, 2024
Member
Mossaka
left a comment
Mossaka
left a comment
There was a problem hiding this comment.
Roughly reviewed it, and it LGTM. I will take a more careful look tomorrow if needed.
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
feat/marketplace-init
branch
from
ab82c18 to
bafb733
Compare
Collaborator
Author
|
I just pushed a few updates to the READMEs in marketplace and the marketplace chart, otherwise everything is the same as previously reviewed. @Mossaka should we merge this in and continue iterating from there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial
marketplace/directory to hold assets associated with a SpinKube Azure Marketplace offeringThis first PR focuses on the Helm chart(s).
Draft for now, hoping for early feedback from @Mossaka
marketplace, owing to the fact that all the charts currently need to be copied in locallycrdsfolder