fix "resource has children" error in spin_sdk.http.send
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were neglecting to drop the resource returned by `incoming-response.headers` prior to dropping the `incoming-response` itself. Either I'm crazy and this never worked or `wasmtime-wasi` wasn't enforcing this parent-child relationship last time I tested it. Either way, this points to an urgent need for CI test coverage. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
karthik2804
approved these changes
Jan 27, 2025
Contributor
karthik2804
left a comment
karthik2804
left a comment
There was a problem hiding this comment.
It definitely worked in the past. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were neglecting to drop the resource returned by
incoming-response.headersprior to dropping theincoming-responseitself. Either I'm crazy and this never worked orwasmtime-wasiwasn't enforcing this parent-child relationship last time I tested it. Either way, this points to an urgent need for CI test coverage.