fix crash on Windows; add version embedding #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue causing `wizer` to fail due to `CPython` calling `fd_filestat_get` on stdio descriptors, which causes Wasmtime's WASI implementation to trap if those descriptors don't point to actual files. This also updates the `spin-sdk` dependency to allow version embedding per https://github.com/fermyon/spin/blob/main/docs/content/sips/011-component-versioning.md. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
karthik2804
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue causing
wizerto fail due toCPythoncallingfd_filestat_geton stdio descriptors, which causes Wasmtime's WASI implementation to trap if those descriptors don't point to actual files.This also updates the
spin-sdkdependency to allow version embedding perhttps://github.com/fermyon/spin/blob/main/docs/content/sips/011-component-versioning.md.