Skip to content

bump version to 0.3.2 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2023
Merged

bump version to 0.3.2 #54

merged 2 commits into from
Sep 28, 2023

Conversation

@dicej
Copy link
Collaborator

@dicej dicej commented Sep 28, 2023

No description provided.

@dicej
bump version to 0.3.1
0aa0a11 
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej dicej requested a review from karthik2804 September 28, 2023 16:22
karthik2804
karthik2804 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking but is there a reason we are bumping patch instead of minor?

@dicej
Copy link
Collaborator Author

dicej commented Sep 28, 2023

Not blocking but is there a reason we are bumping patch instead of minor?

AFAIK we haven't made any breaking changes, and I'm following the Rust style semver convention that pre-1.0 minor version bumps mean breaking changes.

@karthik2804
Copy link
Contributor

karthik2804 commented Sep 28, 2023

@dicej we also need to bump the spin compatibility version in manifest/spin-compat. It is currently pointing at 0.9 but llms need 1.5.

@dicej
update spin compat version to 1.5
d242fc7 
This is needed to support the LLM interface.  Also bumping the version to 0.3.2
since I already tagged 0.3.1 (oops).

Signed-off-by: Joel Dice <joel.dice@fermyon.com>
@dicej dicej changed the title bump version to 0.3.1 bump version to 0.3.2 Sep 28, 2023
karthik2804
karthik2804 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dicej
Copy link
Collaborator Author

dicej commented Sep 28, 2023

Ok, updated the spin compat version and updated the SDK version again to 0.3.2 since I already tagged 0.3.1.

@karthik2804
Copy link
Contributor

karthik2804 commented Sep 28, 2023

We need to merge before the tag so that CI, picks up the version changes for both the binary and plugin package.

@dicej
Copy link
Collaborator Author

dicej commented Sep 28, 2023

We should probably add a Releasing section to README.md that documents the release process. Clearly I've forgotten.

@dicej dicej merged commit 17e05cc into main Sep 28, 2023
@dicej dicej deleted the version-0.3.1 branch September 28, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthik2804 karthik2804 karthik2804 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dicej @karthik2804