fix(artifacts): Exclude unmatchable expected artifact types

[jkschneider]

• Exclude front50 artifact account from trigger artifact constraints.
• Exclude front50, docker, and k8s artifact accounts from CF deploy stage configuration.

[jkschneider]

We now constrain the selection of an artifact account for a Match Artifact for certain trigger types. For example, it isn't possible that an Artifactory trigger will produce an artifact that is matchable to a Github artifact account.

At some point if we remove ArtifactDecorator from Igor, it will no longer be possible that a Jenkins trigger would produce an artifact that matches anything other than a Jenkins artifact account.

Notice though, that the default artifact account selection is not similarly constrained. We do strike K8S and Front50 artifact accounts from the Default Artifact on all trigger types, however.

[ghost]

You can achieve the same as Object.keys(o).map(k => o[k]) with Object.values(o).

I also suggest avoiding as casts as much as possible. Giving ArtifactTypePatterns the IArtifactTypePatterns signature should let us leverage the type checker instead of short-circuiting it for this kind of thing:

export const ArtifactTypePatterns: IArtifactTypePatterns = {
  // ...
};
Object.keys(ArtifactTypePatterns).map(k => ArtifactTypePatterns[k]) // <- should now infer the type as RegExp[]

[jkschneider]

I think Object.values() was introduced in ES2017, but I believe we are still using ES2015? Originally I did the as cast because I found it undesirable to export IArtifactTypePatterns, but I guess there is no issue with that, so will change it.

[jkschneider]

@sbwsg Type change made in b9a2eb5. Can you re-review?

[jkschneider]

@spinnakerbot cherry-pick 1.13

[spinnakerbot]

Cherry pick successful: #6728