Add support for collections #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently just support tables + basic support for gallery view
| type: "collection_view"; | ||
| } | ||
|
|
||
| interface TableGalleryType extends BaseValueType { |
Contributor
There was a problem hiding this comment.
Maybe this should be GalleryCollectionType since it's not a table?
transitive-bullshit
approved these changes
Jun 30, 2020
Contributor
transitive-bullshit
left a comment
transitive-bullshit
left a comment
There was a problem hiding this comment.
Looks awesome @tobiaslins 💪
Just one small note.
I'm sure there will be follow-up work once this is merged, but overall it looks like a really solid start.
Available in beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently just support tables + basic support for gallery view