Start adding support for ugc hint in nofollow external links #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This one can be changed as well? Notes: Maybe we need to squash commits before merging? |
splitbrain
approved these changes
Sep 13, 2019
Collaborator
splitbrain
left a comment
splitbrain
left a comment
There was a problem hiding this comment.
LGTM I'd be fine with merging it without squashing
Contributor
Author
|
Updated EN Lang |
splitbrain
added a commit
that referenced
this pull request
Oct 31, 2019
We use the ugc (user generated content) value for no-follow links since #2855 this is not yet supported in the validator. This patch introduces a list of ignored error messages.
Collaborator
|
FYI currenly HTML validitor will fail on this (we are ignoring the error so far). See validator/validator#878. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #2852