honor userewrite setting in redirection from index.php #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
At first I thought "Seriously, a one line PR fails checks ????" (well, it could be, of course but that's unlikely...) Then I saw that the error lies in |
phy25
approved these changes
Jun 3, 2020
Collaborator
phy25
left a comment
phy25
left a comment
There was a problem hiding this comment.
I reran the test after a fix was committed by splitbrain to master, which is passing now. Thanks for fixing this :-)
Collaborator
|
The previous change of this line was due to #2706. Could you verify this issue is not reappearing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
index.php redirects to "doku.php" whatever the userewrite setting is. This PR uses
wl(). The redirection will respect configured userewrite.Fixes #3164.