Display the list of allowed mime types in media uploader #3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitbrain
reviewed
Jul 22, 2020
Collaborator
|
I just gave it a try. Works fine and is a useful improvement. However, I'm not so happy with the UI. I would prefer this to a) take up less space (maybe move it next to the browse button?)
|
Contributor
Author
|
What about putting it next to the upload limit? The upload form is built completely in JavaScript, so to access the mime types, they would have to be part of JSINFO, which is probably unnecessary. |
Collaborator
|
Both are limitations of what you can upload, so yes, it's fine to have them together. |
Contributor
Author
|
The UI is much more compact now. The recent Travis failure seems to be unrelated and random. @splitbrain could you please re-trigger the build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usability improvement: displays mime types which are whitelisted in the configuration.