Skip to content

Updated typos #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

Updated typos #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7500a73
Updated typos
nmayorsplit Oct 22, 2025
86c1096
Updated
nmayorsplit Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions synchronizer/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type Manager interface {
Start()
Stop()
IsRunning() bool
StartBGSyng(mstatus chan int, shouldRetry bool, onReady func()) error
StartBGSync(status chan int, shouldRetry bool, onReady func()) error
}

// ManagerImpl struct
Expand Down Expand Up @@ -255,10 +255,10 @@ func (s *ManagerImpl) enableStreaming() {
s.hcMonitor.Reset(hc.LargeSegments, int(nextExp.Seconds()))
}

func (m *ManagerImpl) StartBGSyng(mstatus chan int, shouldRetry bool, onReady func()) error {
func (m *ManagerImpl) StartBGSync(status chan int, shouldRetry bool, onReady func()) error {
attemptInit := func() bool {
go m.Start()
status := <-mstatus
status := <-status
switch status {
case Ready:
onReady()
Expand Down
6 changes: 3 additions & 3 deletions synchronizer/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ func TestStartBGSyncSuccessFirstTry(t *testing.T) {
readyCalled := false
onReady := func() { readyCalled = true }

err := manager.StartBGSyng(status, false, onReady)
err := manager.StartBGSync(status, false, onReady)
if err != nil {
t.Error("Should not return error on successful first try")
}
Expand Down Expand Up @@ -968,7 +968,7 @@ func TestStartBGSyncFailNoSnapshot(t *testing.T) {
readyCalled := false
onReady := func() { readyCalled = true }

err := manager.StartBGSyng(status, false, onReady)
err := manager.StartBGSync(status, false, onReady)
if err != errUnrecoverable {
t.Error("Should return errUnrecoverable when sync fails and no snapshot available")
}
Expand Down Expand Up @@ -1011,7 +1011,7 @@ func TestStartBGSyncFailWithSnapshot(t *testing.T) {
readyCalled := false
onReady := func() { readyCalled = true }

err := manager.StartBGSyng(status, true, onReady)
err := manager.StartBGSync(status, true, onReady)
if err != errRetrying {
t.Error("Should return errRetrying when sync fails but snapshot is available")
}
Expand Down
2 changes: 1 addition & 1 deletion synchronizer/redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ func (m *ManagerRedisImpl) IsRunning() bool {
return m.running.IsSet()
}

func (m *ManagerRedisImpl) StartBGSyng(mstatus chan int, shouldRetry bool, onReady func()) error {
func (m *ManagerRedisImpl) StartBGSync(status chan int, shouldRetry bool, onReady func()) error {
return nil
}
Loading