Skip to content

Conversation

@mmelograno
Copy link
Contributor

PHP SDK

What did you accomplish?

  • Updated dependencies to allow psr/log 2 and 3.
  • Removed phpdocumentor/phpdocumentor dependency.
  • Updated Logger and LoggerTrait to be compliant with psr/log 3.

How do we test the changes introduced in this PR?

Extra Notes

Copy link
Contributor

@mredolatti mredolatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmelograno mmelograno requested a review from a team September 5, 2022 20:18
@mmelograno
Copy link
Contributor Author

Hi @cv65kr,

We've deployed this changes to our testing environment with different log configurations to validate that everything's working properly. It will be officially released in a couple of days. If you wish to give this a try and provide us with feedback it would be great. You can do so by referencing dev-maintenance/psr#0dbe5c1 in your composer.json file.

Thanks,
Matias

@cv65kr
Copy link

cv65kr commented Sep 6, 2022

Hi @mmelograno I already tested and looks like it working properly :)

@sonarqube-pull-requests
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@mmelograno mmelograno merged commit 90fc5b4 into develop Sep 6, 2022
@mmelograno mmelograno deleted the maintenance/psr branch January 18, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants