fix: incorrect arg count local mode #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides regression coverage that the LocalhostSplitManager is providing sufficient arguments to the SplitView constructor, both validating and ensuring no regressions of issue splitio#240. Ref: splitio#240
tcarrio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP SDK
What did you accomplish?
Resolved an incorrect argument count when constructing SplitView inside LocalhostSplitManager.
This was a 100% failure rate code path that made local mode impossible to use in 7.3.0 (haven't validated earlier versions, but the line was committed 21 months prior).
How do we test the changes introduced in this PR?
A new test was added to the tests suite. This ensure the failure mode does not exist and serves as a regression test for LocalhostSplitManager going forward.
Extra Notes
Closes #240.