[FME-10128] Use split factory to initialize provider

.nvmrc

@@ -0,0 +1 @@
+22

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/openfeature-web-split-provider",
-  "version": "1.1.0",
+  "version": "1.0.0",
   "description": "Split OpenFeature Web Provider",
   "files": [
     "README.md",
@@ -17,6 +17,12 @@
   "bugs": "https://github.com/splitio/split-openfeature-provider-web-js/issues",
   "license": "Apache-2.0",
   "author": "Josh Sirota <josh.sirota@split.io>",
+  "contributors": [
+    "Nicolas Zelaya <nicolas.zelaya@harness.io> (https://github.com/NicoZelaya)",
+    "Emiliano Sanchez <emiliano.sanchez@harness.io> (https://github.com/EmilianoSanchez)",
+    "Emmanuel Zamora <emmanuel.zamora@harness.io> (https://github.com/ZamoraEmmanuel)",
+    "SDK Team <sdks@harness.io>"
+  ],
   "main": "lib/index.js",
   "module": "es/index.js",
   "browser": "lib/index.js",

src/__tests__/integration/debug.test.js

@@ -8,7 +8,7 @@ describe('OpenFeature Split Provider - Debug Tests', () => {
 
   beforeAll(async () => {
     // Create with more debug options
-    splitClient = SplitFactory({
+    const splitFactory = SplitFactory({
       core: {
         authorizationKey: 'localhost',
       },
@@ -20,7 +20,8 @@ describe('OpenFeature Split Provider - Debug Tests', () => {
         'obj_feature': '{"key": "value"}'
       },
       debug: true
-    }).client();
+    })
+    splitClient =splitFactory.client();
 
     // Add direct Split client test to verify it works as expected
     console.log('Direct Split client test:');
@@ -30,9 +31,7 @@ describe('OpenFeature Split Provider - Debug Tests', () => {
     console.log('- obj_feature:', splitClient.getTreatment('obj_feature'));
 
     // Create provider
-    const provider = new OpenFeatureSplitProvider({
-      splitClient
-    });
+    const provider = new OpenFeatureSplitProvider(splitFactory);
 
     // Register provider
     OpenFeature.setProvider(provider);

src/__tests__/integration/e2e.test.js

@@ -12,7 +12,7 @@ describe('OpenFeature Split Provider - E2E Integration Tests', () => {
   // Set up before all tests
   beforeAll(async () => {
     // Initialize the Split client in localhost mode
-    splitClient = SplitFactory({
+    const splitFactory = SplitFactory({
       core: {
         authorizationKey: 'localhost'
       },
@@ -32,7 +32,8 @@ describe('OpenFeature Split Provider - E2E Integration Tests', () => {
           treatment: '{"key": "value"}'
         }
       }
-    }).client();
+    })
+    splitClient = splitFactory.client();
 
     // Wait for the client to be ready
     await new Promise((resolve) => {
@@ -55,9 +56,7 @@ describe('OpenFeature Split Provider - E2E Integration Tests', () => {
     });
 
     // Create the Split provider with the real Split client
-    const provider = new OpenFeatureSplitProvider({
-      splitClient
-    });
+    const provider = new OpenFeatureSplitProvider(splitFactory);
 
     // Register the provider with OpenFeature
     OpenFeature.setProvider(provider);

src/__tests__/integration/mock.test.js

@@ -36,9 +36,7 @@ describe('OpenFeature Split Provider - Mock Integration Tests', () => {
     };
 
     // Create the provider with our mock Split client
-    provider = new OpenFeatureSplitProvider({
-      splitClient: mockSplitClient
-    });
+    provider = new OpenFeatureSplitProvider({ client: () => mockSplitClient});
 
     // Register with OpenFeature
     OpenFeature.setProviderAndWait(provider);

src/__tests__/integration/working.test.js

@@ -5,7 +5,7 @@ import { OpenFeatureSplitProvider } from '../../lib/js-split-provider';
 describe('OpenFeature Split Provider - Working Integration Test', () => {
   let client;
   let provider;
-  let options;
+  let splitClient;
 
   // Properly define the split treatments for localhost mode
   const localFeatures = {
@@ -21,15 +21,15 @@ describe('OpenFeature Split Provider - Working Integration Test', () => {
 
   beforeEach(async () => {
     // Create client
-    const splitClient = SplitFactory({
+    const splitFactory = SplitFactory({
       core: {
         authorizationKey: 'localhost'
       },
       features: localFeatures
-    }).client();
+    })
+    splitClient = splitFactory.client();
 
-    options = {splitClient}
-    provider = new OpenFeatureSplitProvider(options);
+    provider = new OpenFeatureSplitProvider(splitFactory);
 
     OpenFeature.setProvider(provider);
     OpenFeature.setContext({targetingKey: 'user1'})
@@ -38,7 +38,7 @@ describe('OpenFeature Split Provider - Working Integration Test', () => {
   });
 
   afterEach(async () => {
-    await options.splitClient.destroy();
+    await splitClient.destroy();
   });
 
   test('boolean treatment evaluations', async () => {

src/__tests__/provider-unit.test.js

@@ -41,7 +41,7 @@ describe('OpenFeatureSplitProvider Unit Tests', () => {
 
     // Create the provider with our mock client
     provider = new OpenFeatureSplitProvider({
-      splitClient: mockSplitClient
+      client: () => mockSplitClient
     });
   });
 

src/__tests__/webSuites/client.spec.js

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-import { OpenFeature } from '@openfeature/web-sdk';
+import { OpenFeature, OpenFeatureEventEmitter, ProviderEvents } from '@openfeature/web-sdk';
 import { SplitFactory } from '@splitsoftware/splitio-browserjs';
 import { OpenFeatureSplitProvider } from '../..';
 
@@ -26,6 +26,10 @@ jest.mock('@splitsoftware/splitio-browserjs', () => {
     // Add ready method for web SDK
     ready: jest.fn(() => true),
     __getStatus: () => ({isReady: true}),
+    Event: {
+      'SDK_UPDATE': 'SDK_UPDATE'
+    },
+    on: () => {},
     // Add event registration compatible with web SDK
     addListener: jest.fn(({ event, handler }) => {
       if (event === 'SDK_READY') {
@@ -155,6 +159,12 @@ jest.mock('@openfeature/web-sdk', () => {
   };
 
   return {
+    OpenFeatureEventEmitter: () => ({
+      emit: () => {}
+    }),
+    ProviderEvents: {
+      Ready: 'ready'
+    },
     OpenFeature: {
       setProvider: jest.fn(),
       getClient: jest.fn(() => mockClient)
@@ -304,14 +314,15 @@ export default async function() {
   };
 
   // Configure Split client for web environment
-  let splitClient = SplitFactory({
+  let splitFactory = SplitFactory({
     core: {
       authorizationKey: 'localhost'
     },
     features: mockFeatures,
-  }).client();
+  });
+  let splitClient = splitFactory.client();
 
-  let provider = new OpenFeatureSplitProvider({splitClient});
+  let provider = new OpenFeatureSplitProvider(splitFactory);
   OpenFeature.setProvider(provider);
 
   let client = OpenFeature.getClient('test');

src/lib/js-split-provider.ts

@@ -12,13 +12,10 @@ import {
   Logger,
   ProviderEvents,
   OpenFeature,
+  OpenFeatureEventEmitter,
 } from "@openfeature/web-sdk";
 import type SplitIO from "@splitsoftware/splitio/types/splitio";
 
-export interface SplitProviderOptions {
-  splitClient: SplitIO.IBrowserClient;
-}
-
 type Consumer = {
   key: string | undefined;
   attributes: SplitIO.Attributes;
@@ -30,32 +27,28 @@ export class OpenFeatureSplitProvider implements Provider {
   metadata = {
     name: "split",
   };
-  private initialized: Promise<void>;
   private client: SplitIO.IBrowserClient;
+  public readonly events = new OpenFeatureEventEmitter();
 
-  constructor(options: SplitProviderOptions) {
-    this.client = options.splitClient;
-
-    // Create initialization promise
-    this.initialized = new Promise<void>((resolve) => {
+  constructor(splitFactory: SplitIO.IBrowserSDK) {
+    this.client = splitFactory.client();
+    this.client.on(this.client.Event.SDK_UPDATE, () => {
+      this.events.emit(ProviderEvents.ConfigurationChanged)
+    });
 
-      const onSdkReady = () => {
-        console.log(`${this.metadata.name} provider initialized`);
-        resolve();
-      };
+    const onSdkReady = () => {
+      console.log(`${this.metadata.name} provider initialized`);
+      this.events.emit(ProviderEvents.Ready)
+    };
 
-      // If client is ready, resolve immediately
-      if (this.isClientReady()) {
-        onSdkReady();
-      } else {
-        this.client.on(this.client.Event.SDK_READY, onSdkReady);
-      }
-    }).catch((e) => {
-      // In case of any issues, resolve the promise to prevent hanging
-      console.warn(`${this.metadata.name} provider initialization error: ${e}`);
-    });
+    // If client is ready, resolve immediately
+    if (this.isClientReady()) {
+      onSdkReady();
+    } else {
+      this.client.on(this.client.Event.SDK_READY, onSdkReady);
+    }
   }
-  
+
   // Safe method to check if client is ready
   private isClientReady(): boolean {
     return (this.client as any).__getStatus().isReady;