Skip to content

redis < 6 cluster hostname workaround #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2024
Merged

redis < 6 cluster hostname workaround #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
424f382
forward single server name when connecting to multiple redis hosts in…
mredolatti Apr 3, 2024
48e4d29
Merge branch 'semver' into fix/oldredis_cluster_workaround
mredolatti May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
5.8.0 (May XX, 2024)
- Added support for targeting rules based on semantic versions (https://semver.org/).
- Added special impression label "targeting rule type unsupported by sdk" when the matcher type is not supported by the SDK, which returns 'control' treatment.
- Forward TLS server name when in redis-sentinel & redis-cluster

5.7.0 (TD)
5.7.0 (TBD)
- Add support for FIPS-compliant binaries & docker images

5.6.1 (Jan 29, 2024)
Expand Down
10 changes: 3 additions & 7 deletions splitio/producer/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,9 @@ func parseTLSConfig(opt *conf.Redis) (*tls.Config, error) {
return nil, nil
}

cfg := tls.Config{}
if !opt.SentinelReplication && !opt.ClusterMode {
if opt.TLSServerName != "" {
cfg.ServerName = opt.TLSServerName
} else {
cfg.ServerName = opt.Host
}
cfg := tls.Config{ServerName: opt.TLSServerName}
if cfg.ServerName == "" {
cfg.ServerName = opt.Host
}

if len(opt.TLSCACertificates) > 0 {
Expand Down