Remove legacy methods #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if that would cause breakages for anyone, maybe we can add deprecation warnings in for a release just to give anyone a heads up? |
User class fix, adding specs cleaned up old experiments on Trial.choose since user is memoized; also cleaned up experiments that have not started Fix specs Remove pry Add whitespace Reword a user spec description Fix specs Add the README note
Add deprecation warnings
…into remove_legacy_code
|
@andrew Good point! I've updated the code. |
|
👍 I've added a reminder to my calendar to come back and remove these in a couple of months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andrew Cleaning up some legacy code