Skip to content

Remove legacy methods #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2016
Merged

Remove legacy methods #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
236455c
Remove legacy methods
andreibondarev Apr 22, 2016
4674b51
Add deprecation warnings
andreibondarev Apr 25, 2016
5e670e8
Clean up experiments that are gone, stopped or a winner has been chosen
andreibondarev Apr 20, 2016
6f6b07f
Add deprecation warnings
andreibondarev Apr 22, 2016
4dd2c30
Merge branch 'remove_legacy_code' of github.com:andreibondarev/split …
andreibondarev Apr 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/split/encapsulated_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Split's helper exposes all kinds of methods we don't want to
# mix into our model classes.
#
# This module exposes only two methods
# - ab_test and
# - ab_test_finished
# This module exposes only two methods:
# - ab_test()
# - finished()
# that can safely be mixed into any class.
#
# Passes the instance of the class that it's mixed into to the
Expand Down Expand Up @@ -44,6 +44,7 @@ def ab_test(*arguments)
end

def ab_test_finished(*arguments)
warn 'DEPRECATION WARNING: ab_test_finished is deprecated and will be removed from Split 1.5.0'
split_context_shim.finished *arguments
end

Expand Down
1 change: 1 addition & 0 deletions lib/split/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def split_generically_disabled?
end

def begin_experiment(experiment, alternative_name = nil)
warn 'DEPRECATION WARNING: begin_experiment is deprecated and will be removed from Split 1.5.0'
alternative_name ||= experiment.control.name
ab_user[experiment.key] = alternative_name
alternative_name
Expand Down