Condense built-in and DSL RSpec matcher inspection output#203
Conversation
Collaborator
|
Thanks so much! |
Collaborator
|
I updated the inspector you added to also consider custom-from-scratch matchers. This is included in v0.11.0. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In diff output, some RSpec matchers, such as custom DSL-defined matchers and built-ins like
be_a, are treated as default objects. This means that their fully-qualified class names and all instance variables are recursively printed, which can make the output quite verbose! Here's a very small example spec:which outputs the following diff:
You can imagine this could get much longer with more complex expectations.
Solution
Use the matcher's description on inspection. For the case above, this results in the following: