Conversation
This commit makes some minor changes to the `raise_error` matcher to
make the failure messages slightly more friendly and consistent with
the overall philosophy of matchers in this repo.
Here are the current messages in comparison with the new ones:
- In cases where the block raises no error, the wording changes
from "Expected block" to "Expected exception-free block", and
"exception-free block" is highlighted in the actual color. This is to
emphasize the actual behavior vs. the expected behavior and matches
other matchers.
- In cases where only an expected error class is provided, the wording
changes so that instead of inspecting the expected error, the failure
message says "a kind of" followed by the class name.
- In cases where a message is provided, the expected class and message
are separated in the failure message.
- In cases where a regexp message is provided, the wording changes from
"with message #{message}" to "with message matching #{message}".
Additionally, the integration tests for `raise_error` have been reviewed
and missing tests have been filled in.
13b0772 to
8693014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes some minor changes to the
raise_errormatcher to make the failure messages slightly more friendly and consistent with the overall philosophy of matchers in this repo.Here are the current messages in comparison with the new ones:
Additionally, the integration tests for
raise_errorhave been reviewed and missing tests have been filled in.