Fix hash diffing algorithm #293
Merged
+378
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99.
This rewrites the hash diffing algorithm to leverage LCS on the hash keys, maintaining the goal of preserving the order of the
actualkeys where possible.This causes a couple notable changes. Previously, changes to a shared key's value were sometimes rendered as separate deletes and inserts. These changes are now always visually colocated as a delete of the old value followed immediately by an insert of the new value.
Additionally, keys at the beginning of
expectedthat are not inactualwere previously rendered as deletes at the end of the diff. These are now rendered at the beginning, reflecting the key ordering relative toactualmore accurately.