fix(code): ADDON-58030 parse all definitions of true for splunkd scheme #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 111 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 0 | 24 | 87 | 0 |
Click to see the invalid file list
- pyproject.toml
- solnlib/init.py
- solnlib/_utils.py
- solnlib/acl.py
- solnlib/conf_manager.py
- solnlib/credentials.py
- solnlib/file_monitor.py
- solnlib/hec_config.py
- solnlib/log.py
- solnlib/modular_input/init.py
- solnlib/modular_input/checkpointer.py
- solnlib/modular_input/event.py
- solnlib/modular_input/event_writer.py
- solnlib/modular_input/modular_input.py
- solnlib/net_utils.py
- solnlib/orphan_process_monitor.py
- solnlib/pattern.py
- solnlib/server_info.py
- solnlib/splunk_rest_client.py
- solnlib/splunkenv.py
- solnlib/time_parser.py
- solnlib/timer_queue.py
- solnlib/user_access.py
- solnlib/utils.py
hetangmodi-crest
requested review from
artemrys and
okashaev-splunk
as code owners
artemrys
force-pushed
the
fix/ADDON-58030-fetch-correct-splunkd-scheme
branch
from
edb697b to
a29476e
Compare
Member
|
Fixed copyright checker in main already, so rebasing your PR. |
artemrys
approved these changes
Nov 10, 2022
Contributor
|
🎉 This PR is included in version 4.8.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other values of
trueare passed inserver.confsuch as1,TRUE,T, the Splunkd URI was incorrectly formed, hence by using theis_true()function, all the values are parsed in an expected manner.