Skip to content

fix(code): ADDON-58030 parse all definitions of true for splunkd scheme #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix(code): ADDON-58030 parse all definitions of true for splunkd scheme #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# IDE related files
*.idea
*.DS_Store*
.venv/

# Compiled files
__pycache__
*.pyc
*.pyo
.coverage

.coverage
4 changes: 3 additions & 1 deletion solnlib/splunkenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
from io import StringIO
from typing import List, Optional, Tuple, Union

from .utils import is_true

__all__ = [
"make_splunkhome_path",
"get_splunk_host_info",
Expand Down Expand Up @@ -177,7 +179,7 @@ def get_splunkd_access_info() -> Tuple[str, str, int]:
Tuple of (scheme, host, port).
"""

if get_conf_key_value("server", "sslConfig", "enableSplunkdSSL") == "true":
if is_true(get_conf_key_value("server", "sslConfig", "enableSplunkdSSL")):
scheme = "https"
else:
scheme = "http"
Expand Down