Added /opt/splunk/etc to image and made some updates to splunk's home #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwang92
approved these changes
Jun 12, 2019
arctan5x
approved these changes
Jun 14, 2019
kyanite
reviewed
Jun 17, 2019
| # Setup users and groups | ||
| RUN groupadd -r -g ${GID} ${SPLUNK_GROUP} \ | ||
| && useradd -r -m -u ${UID} -g ${GID} ${SPLUNK_USER} \ | ||
| && useradd -r -m -u ${UID} -g ${GID} -s /sbin/nologin -d ${SPLUNK_HOME} ${SPLUNK_USER} \ |
There was a problem hiding this comment.
Change home of splunk user in here will broken internal splunk-orca image.
In my understanding, $SPLUNK_HOME is /opt/splunk, but the user splunk's home is better as /home/splunk
And also this PR broken the splunk-orca in https://git.splunk.com/projects/TOOLS/repos/infra-internal-base-images/browse/splunk-orca/x64_debian_9/Dockerfile
Contributor
Author
There was a problem hiding this comment.
It seemed confusing to me to have a "SPLUNK_HOME" which was not the same as the home directory for the user splunk. I assumed this was made different inadvertently by not explicitly specifying a home to useradd. I don't feel strongly about it one way or the other, and am curious to learn benefits of splitting it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking this would fix the /opt/splunk/etc permission failures in splunk-ansible