openshift comply #220
Merged
openshift comply #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendolim
requested review from
arctan5x,
bb03,
jmeixensperger,
lephino,
mikedickey and
nwang92
Contributor
Author
|
Update: the splunk-ubi8 image passed Openshift scan
|
nwang92
reviewed
Aug 7, 2019
lephino
approved these changes
Aug 7, 2019
bb03
reviewed
Aug 7, 2019
| LABEL name="splunk" \ | ||
| maintainer="support@splunk.com" \ | ||
| vendor="splunk" \ | ||
| version="7.3.1" \ |
Contributor
There was a problem hiding this comment.
This is fine to hardcode for now, but in the future we should update this to be whatever the splunk version is from our Makefile
bb03
approved these changes
Aug 7, 2019
mikedickey
reviewed
Aug 8, 2019
| # NOTE that since OpenShift Container Platform 3.11 | ||
| # the container catalog moved from registry.access.redhat.com to registry.redhat.io | ||
| # So at some point before they deprecate the old registry we have to make sure that | ||
| # we have access to the new registry and change where we pull the ubi image from. |
Contributor
There was a problem hiding this comment.
Please your provide reference for this, since all the docs for UBI images seem to reference registry.access.redhat.com, and these were published concurrent with the release of 4.0, which is long after 3.11 was released.
| summary="UBI 8 Docker image of Splunk Enterprise" \ | ||
| description="Splunk Enterprise is a platform for operational intelligence. Our software lets you collect, analyze, and act upon the untapped value of big data that your technology infrastructure, security systems, and business applications generate. It gives you insights to drive operational performance and business results." | ||
|
|
||
| RUN mkdir /licenses; \ |
Contributor
There was a problem hiding this comment.
We should probably combine this with the RUN command below, so that we are not unnecessarily creating an additional image layer.
Contributor
|
Sorry I didn't realize GitHub requires clicking "Submit review" for my comments to be sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the ubi8 image to abide to RedHat Openshift requirements (labels and licenses)