Updating splunk version #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwang92
requested review from
arctan5x,
bb03,
hendolim,
jmeixensperger,
jonathan-vega-splunk,
jrigassio-splunk and
lephino
Contributor
Author
|
Hmm maybe this PR should go directly into |
arctan5x
previously approved these changes
Oct 21, 2019
hendolim
previously approved these changes
Oct 21, 2019
hendolim
approved these changes
Oct 22, 2019
hendolim
reviewed
Oct 22, 2019
| echo "current $1 image size = "$$CUR_SIZE ; \ | ||
| echo "edge image size = "$$EDGE_SIZE ; \ | ||
| if [[ $$CUR_SIZE -gt $$EDGE_SIZE*120/100 ]] ; then echo "current image size is 20% more than edge image" ; exit 1 ; fi | ||
| if [[ $$CUR_SIZE -gt $$EDGE_SIZE*140/100 ]] ; then echo "current image size is 40% more than edge image" ; exit 1 ; fi |
Contributor
There was a problem hiding this comment.
Is it the splunk binary that has gotten so big?
Contributor
There was a problem hiding this comment.
it was ad hoc change in order to accommodate the release ;)
Contributor
There was a problem hiding this comment.
Also, Splunk 8.0.0 vs 7.3.2 saw about 30% increase for linux distro when unextraced.
arctan5x
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will fail until the bits have been published, but I'm updating the version and hash anyways because we'll want it to tie off the release.