Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

converted divisor to float for cpu metrics #108

Merged
merged 2 commits into from
Jan 25, 2022
Merged

converted divisor to float for cpu metrics #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ab372
converted divisor to float for cpu metrics
hvaghani221 Jan 17, 2022
2abefe8
updated unit test
hvaghani221 Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/fluent/plugin/in_kubernetes_metrics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def emit_cpu_metrics(tag:, metrics:, labels:)
unless metrics['time'].nil?
time = parse_time metrics['time']
if usage_rate = metrics['usageNanoCores']
router.emit generate_tag("#{tag}.cpu.usage_rate"), time, labels.merge('value' => usage_rate / 1_000_000)
router.emit generate_tag("#{tag}.cpu.usage_rate"), time, labels.merge('value' => usage_rate / 1_000_000.0)
end
if usage = metrics['usageNanoCores']
router.emit generate_tag("#{tag}.cpu.usage"), time, labels.merge('value' => usage)
Expand Down Expand Up @@ -416,13 +416,13 @@ def emit_stats_breakdown(stats)

def emit_cpu_metrics_stats(tag:, metrics:, labels:, time:)
if cpu_usage_total = metrics['usage']['total']
router.emit generate_tag("#{tag}.cpu.usage.total"), time, labels.merge('value' => cpu_usage_total / 1_000_000)
router.emit generate_tag("#{tag}.cpu.usage.total"), time, labels.merge('value' => cpu_usage_total / 1_000_000.0)
end
if cpu_usage_user = metrics['usage']['user']
router.emit generate_tag("#{tag}.cpu.usage.user"), time, labels.merge('value' => cpu_usage_user / 1_000_000)
router.emit generate_tag("#{tag}.cpu.usage.user"), time, labels.merge('value' => cpu_usage_user / 1_000_000.0)
end
if cpu_usage_system = metrics['usage']['system']
router.emit generate_tag("#{tag}.cpu.usage.system"), time, labels.merge('value' => cpu_usage_system / 1_000_000)
router.emit generate_tag("#{tag}.cpu.usage.system"), time, labels.merge('value' => cpu_usage_system / 1_000_000.0)
end

if cpu_cfs_periods = metrics['cfs']['periods']
Expand Down
2 changes: 1 addition & 1 deletion test/plugin/test_in_kubernetes_metrics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def create_driver(conf = CONFIG)
assert_equal @@parsed_unit_string['node']['cpu']['usageNanoCores'], @@hash_map_test['kube.node.cpu.usage'][2]['value']

assert_not_nil @@hash_map_test.key?('kube.node.cpu.usage_rate')
assert_equal @@parsed_unit_string['node']['cpu']['usageNanoCores'] / 1_000_000, @@hash_map_test['kube.node.cpu.usage_rate'][2]['value']
assert_equal @@parsed_unit_string['node']['cpu']['usageNanoCores'] / 1_000_000.0, @@hash_map_test['kube.node.cpu.usage_rate'][2]['value']
end

test 'test_emit_memory_metrics' do
Expand Down