Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Conversation

@hvaghani221
Copy link
Contributor

When plugin doesn't receives pod memory/cpu metric from summary API, it will accumulate it from containers metric.

@hvaghani221
Copy link
Contributor Author

2 tests are failing due to bug in some_should_be_greater test helper function. I have raised PR to fix that.

@hvaghani221 hvaghani221 marked this pull request as ready for review February 9, 2022 12:54
@hvaghani221 hvaghani221 requested a review from rockb1017 February 9, 2022 12:54
Copy link
Contributor

@rockb1017 rockb1017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rockb1017 rockb1017 merged commit 7b8c681 into develop Feb 11, 2022
@rockb1017 rockb1017 deleted the pod-usages branch February 11, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants