This repository was archived by the owner on Sep 26, 2025. It is now read-only.
CircleCI Release process #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion from file in repo
…sion from file in repo
chaitanyaphalak
suggested changes
Oct 9, 2019
| VERSION_COMMIT=$(git log -1 --format=format:%H VERSION) | ||
| if [ $VERSION_COMMIT = $LATEST_COMMIT ]; | ||
| then | ||
| VERSION=`cat VERSION` |
Contributor
There was a problem hiding this comment.
if VERSION is empty/null/not set abort
Contributor
Author
There was a problem hiding this comment.
Implemented where VERSION is empty. it will error if there is no VERSION file from line 6.
Gemfile.lock
Outdated
| remote: . | ||
| specs: | ||
| fluent-plugin-kubernetes-metrics (1.1.0) | ||
| fluent-plugin-kubernetes-metrics (1.1.1) |
Contributor
There was a problem hiding this comment.
Do we need to update the Gemfile.lock if there are no updates in dependencies?
Contributor
Author
There was a problem hiding this comment.
changes to Gemfile.lock has been removed from this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Circle CI release stage to automatically upload gem to rubygems.org.
For bash scripts to get fluentd HEC plugin version from file in the repo rather than from CircleCI env.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.