Skip to content

Fix code example on OpenTelemetry Collector workshop #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Fix code example on OpenTelemetry Collector workshop #245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70244cc
fix scraper code
katzchang Dec 8, 2023
cc216c9
fix
katzchang Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions content/en/other/opentelemetry-collector/8-develop/5-business-logic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import (
)

type scraper struct {
mb *metadata.Metricsbuilder
mb *metadata.MetricsBuilder
client *jenkins.Jenkins
}

Expand All @@ -57,8 +57,8 @@ func newScraper(cfg *Config, set receiver.CreateSettings) (scraperhelper.Scraper
return scraperhelper.NewScraper(
metadata.Type,
s.scrape,
scarperhelper.WithStart(func(ctx context.Context, h component.Host) error {
client, err := cfg.ToClient(h, set)
scraperhelper.WithStart(func(ctx context.Context, h component.Host) error {
client, err := cfg.ToClient(h, set.TelemetrySettings)
if err != nil {
return err
}
Expand All @@ -68,11 +68,11 @@ func newScraper(cfg *Config, set receiver.CreateSettings) (scraperhelper.Scraper
s.client = jenkins.NewJenkins(nil, cfg.Endpoint)
s.client.SetHTTPClient(client)
return nil
})
}),
)
}

func (scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
// To be filled in
return pmetric.NewMetrics(), nil
}
Expand All @@ -91,7 +91,7 @@ and measure of many projects have onboarded. To do this we will call the jenkins
and if it reports an error, return that with no metrics, otherwise, emit the data from the metric builder.

```go
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
jobs, err := s.client.GetJobs()
if err != nil {
return pmetric.Metrics{}, err
Expand All @@ -118,7 +118,7 @@ there was. Within this step, we are going to examine each job and use the report
to capture metrics.

```go
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
jobs, err := s.client.GetJobs()
if err != nil {
return pmetric.Metrics{}, err
Expand Down Expand Up @@ -171,7 +171,7 @@ The final step is to calculate how long it took from
commit to job completion to help infer our DORA metrics.

```go
func (s scrape) scrape(ctx context.Context) (pmetric.Metrics, error) {
func (s scraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
jobs, err := s.client.GetJobs()
if err != nil {
return pmetric.Metrics{}, err
Expand Down