Skip to content

Conversation

@jayjoshi-crest
Copy link
Contributor

Issue

  • Dictionary is unordered due to which the sample were returned without order.
  • It resulted in flaky failures due to different hostnames.

Fix

  • Sorted the stanzas returned by EventgenParser.

@jayjoshi-crest jayjoshi-crest force-pushed the ACD-4521-generate-the-same-test-ids-for-indextime-tests branch from c0acc32 to 6dd5b19 Compare August 18, 2020 13:26
Copy link
Contributor

@ryanfaircloth ryanfaircloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple fix, wait for tests to pass before merge

@jayjoshi-crest jayjoshi-crest merged commit 126c0fb into develop Aug 19, 2020
@jayjoshi-crest jayjoshi-crest deleted the ACD-4521-generate-the-same-test-ids-for-indextime-tests branch August 19, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants