feat: Adds mechanism to generate tests by parsing savedsearches.conf. #228
Conversation
harshshah2-crest
commented
Dec 29, 2020
harshshah2-crest
commented
- Mechanism to generate tests by parsing savedsearches.conf.
- Documentation Update.
- Added tests in TA_Fiction and TA_Broken.
harshshah2-crest
requested review from
jayjoshi-crest,
nariyanibhargav,
ryanfaircloth and
siddharth-khatsuriya
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
docs/field_tests.rst
Outdated
| test_savedsearches[<savedsearch_stanza>] | ||
| Test case verifies that there are savedsearches mapped with the search. |
There was a problem hiding this comment.
Please update the description. we are not checking the mapping, we are validating that the search produces a result which is mentioned in the saved search
| caplog, | ||
| ): | ||
| """ | ||
| Tests if all savedsearches in savedsearches.conf are generated in Splunk. |
There was a problem hiding this comment.
update the docstring. we are not checking savedsearches are generated. we are testing each saved search is being executed properly and producing results.
| "dispatch.earliest_time" : "0", | ||
| "dispatch.latest_time" : "now"} | ||
| for key in savedsearch_sections.options: | ||
| if key == "search": |
There was a problem hiding this comment.
what happens if search param is not provided in the stanza? the whole execution would stop with an exception.
There was a problem hiding this comment.
Updated code to handle such scenarios and also updated tests in TA_Fiction and TA_Broken accordingly.
…arsing savedsearches.conf.
harshshah2-crest
force-pushed
the
feature/savedsearch-tests
branch
from
2fd0891 to
8e2584a
Compare
|
Expected release notes (by @harshshah2-crest) features:
|
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4 participants
