Feature/acd 4056 merge test cases for empty and dash fields #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahrasidhpuri-crest
requested review from
jayjoshi-crest,
nariyanibhargav and
ryanfaircloth
| op = "" | ||
| for f in splunk_app_fields["fields"]: | ||
| search = search + f' {op} {f}="-"' | ||
| search = search + f' {op} {f}="-" OR {f}=""' |
Contributor
There was a problem hiding this comment.
Can you please update the variable name in the file from f to field
jayjoshi-crest
approved these changes
Apr 1, 2020
ryanfaircloth
approved these changes
Apr 1, 2020
nariyanibhargav
approved these changes
Apr 1, 2020
| op = "OR" | ||
| operator = "" | ||
| for field in splunk_app_fields["fields"]: | ||
| search = search + f' {operator} {field}="-" OR {field}=""' |
Contributor
There was a problem hiding this comment.
Can we add parenthesis to OR for multiple fields.
nariyanibhargav
deleted the
feature/ACD-4056-Merge-test-cases-for-empty-and-dash-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the test cases "props fields with no dash" and "props fields with no empty values" in one.