-
Notifications
You must be signed in to change notification settings - Fork 430
Clean and deploy #2316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Clean and deploy #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for cleaning and deploying.
…tter not to overwrite python builtins.
…nd line version of appinspect.
… errorneous comma from lookups/attack_tools.csv that caused errors during appinspect and resulted in a badly cormatted csv.
Updated command line arguments for build. Improved implmentation of inspect.
a default argument for deploy.
…for distributing the tool standalone in a separate repo as opposed to a part of the security_content repo.
… Successfully built, then manually deployed an app to a Splunk Cloud instance using the ACS command line. The next steps will be to integrate the command line functionality into this app via the deploy option.
…ment of apps to Splunk Cloud using Automated Private App Vetting / APAV
…ether the acs command has failed since even an ACS failure gives a return code of 0. I have raised this issue with the ACS team and am waiting on a reponse and guidance.
in initialize.
enums, and initialize to support building the app scaffold and removing all the content that needs to be removed.
documentation in contentctl help.
…ADME file with usage documentation.
patel-bhavin
previously approved these changes
Aug 11, 2022
…s way, the options flow logically from creation to validation to building to deployment.
patel-bhavin
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in the changes made for the Detection as Code talk by Patrick and Eric at .conf22. These changes allow a user to remove all the Splunk content from security_content so that a user can add their own. They also make it possible to build, validate, and deploy and app to a Splunk Cloud instance using ACS using just the contentctl tool!