Skip to content

Conversation

@vivekr-splunk
Copy link
Collaborator

  • Add continue-on-error to Docker Hub login steps
  • Remove splunk/splunk-ai-operator from image metadata (only use GHCR)
  • Allows workflows to succeed even if Docker Hub credentials are not configured
  • Primary registry remains ghcr.io/splunk/splunk-ai-operator

Changes:

  • main-build-image.yml: Optional Docker Hub login, GHCR-only push
  • main-smoke-tests.yml: Optional Docker Hub login

🤖 Generated with Claude Code

Description

Related Issues

  • Related to #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement
  • CI/CD improvement
  • Chore (dependency updates, etc.)

Changes Made

Testing Performed

  • Unit tests pass (make test)
  • Linting passes (make lint)
  • Integration tests pass (if applicable)
  • E2E tests pass (if applicable)
  • Manual testing performed

Test Environment

  • Kubernetes Version:
  • Cloud Provider:
  • Deployment Method:

Test Steps

Documentation

  • Updated inline code comments
  • Updated README.md (if adding features)
  • Updated API documentation
  • Updated deployment guides
  • Updated CHANGELOG.md
  • No documentation needed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have updated the Helm chart version (if applicable)
  • I have updated CRD schemas (if applicable)

Breaking Changes

Impact:

Migration Path:

Screenshots/Recordings

Additional Notes

Reviewer Notes

Please pay special attention to:


Commit Message Convention: This PR follows Conventional Commits

- Add continue-on-error to Docker Hub login steps
- Remove splunk/splunk-ai-operator from image metadata (only use GHCR)
- Allows workflows to succeed even if Docker Hub credentials are not configured
- Primary registry remains ghcr.io/splunk/splunk-ai-operator

Changes:
- main-build-image.yml: Optional Docker Hub login, GHCR-only push
- main-smoke-tests.yml: Optional Docker Hub login

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes Docker Hub integration optional in GitHub Actions workflows to allow successful execution even when Docker Hub credentials are not configured. The primary container registry remains GitHub Container Registry (GHCR).

  • Adds continue-on-error: true to Docker Hub login steps in both workflows
  • Removes Docker Hub (splunk/splunk-ai-operator) from the image metadata configuration, making GHCR the sole registry target

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/main-build-image.yml Makes Docker Hub login optional and removes Docker Hub from image metadata, ensuring images are only pushed to GHCR
.github/workflows/main-smoke-tests.yml Makes Docker Hub login step optional to prevent workflow failures when Docker Hub credentials are unavailable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19486317062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.822%

Totals Coverage Status
Change from base Build 19484939512: 0.0%
Covered Lines: 2336
Relevant Lines: 6344

💛 - Coveralls

@kupratyu-splunk kupratyu-splunk merged commit c45c5ec into main Nov 19, 2025
14 checks passed
@kupratyu-splunk kupratyu-splunk deleted the fix/release-workflow-go-version branch November 19, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants