-
Notifications
You must be signed in to change notification settings - Fork 126
Fix helm m4 test cases #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helm m4 test cases #1626
Conversation
Pull Request Test Coverage Report for Build 19647377172Details
💛 - Coveralls |
| allSites: "site1,site2" | ||
| site: site1 | ||
| zone: us-west-2d | ||
| zone: us-west-2c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this test case, should we separate cluster deployment from test cases ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's only the m4 cases that this matters due to the different sites. If it's possible to make them cluster agnostic, that would be great, like getting the available zones as inputs instead of hard coding them. It looks like the m4 integration test cases do not set zones, so we could look at how those sites are getting set up and make changes to the helm tests to replicate that.
As you mentioned, the goal of this PR is to stabilize the workflows, so this request can be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ (non-blocking) - where does those new VPC/subnet configs live that required this PR's zone update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubabuczak created new ones in response to a security issue involving our team's AWS account, and were updated in the github secrets that are used by the workflows. Example: https://github.com/splunk/splunk-operator/blob/main/.github/workflows/helm-test-workflow.yml#L58
| allSites: "site1,site2" | ||
| site: site1 | ||
| zone: us-west-2d | ||
| zone: us-west-2c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ (non-blocking) - where does those new VPC/subnet configs live that required this PR's zone update?
Description
This PR stabilizes the m4 helm test cases after new VPC and subnet configurations. The new subnets used create nodes in the zones us-west-2a, us-west-2b, and us-west-2c, so updating the m4 test cases to provision indexers and search heads in those zones stabilized the tests. Green workflow run with these changes: https://github.com/splunk/splunk-operator/actions/runs/19638962105/job/56239903173
Key Changes
Testing and Verification
Related Issues
N/A
PR Checklist