Skip to content

Conversation

@rlieberman-splunk
Copy link
Collaborator

Description

This PR stabilizes the m4 helm test cases after new VPC and subnet configurations. The new subnets used create nodes in the zones us-west-2a, us-west-2b, and us-west-2c, so updating the m4 test cases to provision indexers and search heads in those zones stabilized the tests. Green workflow run with these changes: https://github.com/splunk/splunk-operator/actions/runs/19638962105/job/56239903173

Key Changes

  • Update m4_config.yaml files with correct zones

Testing and Verification

Related Issues

N/A

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2025

Pull Request Test Coverage Report for Build 19647377172

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 86.514%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/cp.go 1 33.33%
Totals Coverage Status
Change from base Build 19641836256: -0.008%
Covered Lines: 10739
Relevant Lines: 12413

💛 - Coveralls

allSites: "site1,site2"
site: site1
zone: us-west-2d
zone: us-west-2c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this test case, should we separate cluster deployment from test cases ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's only the m4 cases that this matters due to the different sites. If it's possible to make them cluster agnostic, that would be great, like getting the available zones as inputs instead of hard coding them. It looks like the m4 integration test cases do not set zones, so we could look at how those sites are getting set up and make changes to the helm tests to replicate that.

As you mentioned, the goal of this PR is to stabilize the workflows, so this request can be done in a separate PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ (non-blocking) - where does those new VPC/subnet configs live that required this PR's zone update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubabuczak created new ones in response to a security issue involving our team's AWS account, and were updated in the github secrets that are used by the workflows. Example: https://github.com/splunk/splunk-operator/blob/main/.github/workflows/helm-test-workflow.yml#L58

allSites: "site1,site2"
site: site1
zone: us-west-2d
zone: us-west-2c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ (non-blocking) - where does those new VPC/subnet configs live that required this PR's zone update?

@qingw-splunk qingw-splunk merged commit 64ce364 into develop Nov 25, 2025
24 of 27 checks passed
@qingw-splunk qingw-splunk deleted the fix_helm_m4 branch November 25, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants