CSPL-620: add test to verify disabled SH dont exist on CM #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhanoya-splunk
force-pushed
the
CSPL-620-add-test-to-verify-sh-removed-from-cm
branch
from
0be0f5b to
9fabd0f
Compare
pdhanoya-splunk
force-pushed
the
CSPL-620-add-test-to-verify-sh-removed-from-cm
branch
3 times, most recently
from
1c7ca33 to
bca42ac
Compare
pdhanoya-splunk
requested review from
akondur,
gaurav-splunk,
jryb,
kashok-splunk,
sgontla and
smohan-splunk
jryb
reviewed
Dec 23, 2020
| var ( | ||
| testenvInstance *testenv.TestEnv | ||
| testSuiteName = "mc-" + testenv.RandomDNSName(2) | ||
| testSuiteName = "ingestsearch-" + testenv.RandomDNSName(2) |
Contributor
There was a problem hiding this comment.
Thanks for fixing this copy/paste error.
jryb
reviewed
Dec 23, 2020
| echo "Running test using these images: ${PRIVATE_SPLUNK_OPERATOR_IMAGE} and ${PRIVATE_SPLUNK_ENTERPRISE_IMAGE}..." | ||
| # run Ginkgo | ||
| ginkgo -v -progress -r -stream -nodes=${NUM_NODES} -skipPackage=example,monitoringconsoletest ${topdir}/test -- -commit-hash=${COMMIT_HASH} -operator-image=${PRIVATE_SPLUNK_OPERATOR_IMAGE} -splunk-image=${PRIVATE_SPLUNK_ENTERPRISE_IMAGE} | ||
| ginkgo -v -progress -r -stream -nodes=${NUM_NODES} --skipPackage=example,ingest_search,monitoring_console,delete_cr ${topdir}/test -- -commit-hash=${COMMIT_HASH} -operator-image=${PRIVATE_SPLUNK_OPERATOR_IMAGE} -splunk-image=${PRIVATE_SPLUNK_ENTERPRISE_IMAGE} |
Contributor
There was a problem hiding this comment.
Which tests are we actually running as part of this? Maybe add a comment mentioning what we would like to run here since it's unclear, at least to me.
Contributor
Author
There was a problem hiding this comment.
Thats a good idea @jryb. We are only running smoke test cases for PR verification's.
jryb
approved these changes
Dec 23, 2020
pdhanoya-splunk
force-pushed
the
CSPL-620-add-test-to-verify-sh-removed-from-cm
branch
from
bca42ac to
7000add
Compare
smohan-splunk
approved these changes
Dec 23, 2020
| } | ||
| }) | ||
|
|
||
| // Disabling this test because of failure. The manual test passes. |
Contributor
There was a problem hiding this comment.
Comment should be removed?
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing out. I will fix it.
pdhanoya-splunk
force-pushed
the
CSPL-620-add-test-to-verify-sh-removed-from-cm
branch
from
a5a29c6 to
1bb0954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.