Skip to content

CSPL-660: Storage class revamp #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 13, 2021
Merged

CSPL-660: Storage class revamp #219

merged 6 commits into from
Jan 13, 2021

Conversation

@akondur
Copy link
Collaborator

@akondur akondur commented Jan 6, 2021 •
edited
Loading

  • Changed the way storage class specifications are configured. Introduced two new fields etcVolumeStorageConfig(for /opt/splunk/etc) and varVolumeStorageConfig(for /opt/splunk/var) with storageClassName, storageCapacity & ephemeralStorage nested under them.
  • Changed docs to reflect the same
  • Unit test to support
  • Functional tests done to verify different combinations of storageCapacity, storageClassName combinations for the two volumes.

@akondur akondur requested review from jryb and sgontla January 6, 2021 02:08
smohan-splunk
smohan-splunk reviewed Jan 8, 2021
View reviewed changes
jryb
jryb reviewed Jan 8, 2021
View reviewed changes
jryb
jryb reviewed Jan 8, 2021
View reviewed changes
jryb
jryb reviewed Jan 8, 2021
View reviewed changes
jryb
jryb reviewed Jan 8, 2021
View reviewed changes
smohan-splunk
smohan-splunk reviewed Jan 8, 2021
View reviewed changes
smohan-splunk
smohan-splunk approved these changes Jan 11, 2021
View reviewed changes
@smohan-splunk smohan-splunk changed the title Storage class revamp CSPL-660: Storage class revamp Jan 13, 2021
@smohan-splunk smohan-splunk merged commit 76ae2a1 into develop Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgontla sgontla Awaiting requested review from sgontla

2 more reviewers

@jryb jryb jryb approved these changes

@smohan-splunk smohan-splunk smohan-splunk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akondur @jryb @smohan-splunk