CSPL-780 Deployer PVCs Not Deleted #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting SHC custom resources we would only delete PVCs with the "search-head" descriptor and ignore those with the "deployer" descriptor despite them both being created by the same custom resource. Fix: When deleting SHC custom resources, delete PVCs for both the "search-head" and "deployer" components.
vebken-splunk
requested review from
akondur,
gaurav-splunk,
pdhanoya-splunk and
smohan-splunk
gaurav-splunk
approved these changes
Mar 24, 2021
akondur
approved these changes
Mar 24, 2021
smohan-splunk
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting SHC custom resources we would only delete PVCs with the "search-head" descriptor and ignore those with the "deployer" descriptor despite them both being created by the same custom resource.
Fix: When deleting SHC custom resources, delete PVCs for both the "search-head" and "deployer" components.