This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Handle cases where we get an empty key for an s:dict entry #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EAI sends us s:dict entries (with nested s:key nodes), we parse them as a dictionary in C#. However, it turns out the API can send us a case where the value for the s:key node is actually the empty string, which we do not expect and actually have a code contract to protect against. In that case, we will change it from the empty string to the string called "empty" to be explicit about it. Since there can only be one empty key per level (otherwise it would be a serious API error), this is a reasonable workaround.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57, but targeting develop instead of master