Fix Configuration(distributed=True) resulting in a command that is NOT distributed #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults in a command that is NOT distributed.
dan1
requested changes
Jul 25, 2017
Contributor
dan1
left a comment
dan1
left a comment
There was a problem hiding this comment.
I had to change
...
line 149
[('type', 'streaming')])
...
line 168
[('required_fields', ['field_1', 'field_2', 'field_3']), ('type', 'stateful')])
| self.assertEqual( | ||
| [(name, value) for name, value in command.configuration.iteritems()], | ||
| [('generating', True), ('type', 'streaming')]) | ||
|
|
Contributor
There was a problem hiding this comment.
I had to change this to
[('generating', True), ('type', 'stateful')])
to get the test to pass.
| self.assertIs(command.configuration.distributed, False) | ||
| self.assertIs(command.configuration.generating, True) | ||
| self.assertEqual(command.configuration.type, 'streaming') | ||
| self.assertEqual(command.configuration.type, 'stateful') |
Contributor
There was a problem hiding this comment.
I had to set this back to get the test to pass.
self.assertEqual(command.configuration.type, 'streaming')
Contributor
|
|
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per support Case #488821, DVPL-7118, DEVC-1
In a generating command using SCP2 (chunked = true), commands are unexpectedly distributed
#!/usr/bin/env python
import sys
import time
import socket
from splunklib.searchcommands import dispatch, GeneratingCommand, Configuration, Option, validators
@configuration(
distributed=False
)
class distfalse(GeneratingCommand):
def generate(self):
yield {'_time': time.time(), '_raw': 'This ran on ' + socket.gethostname()}
self.flush()
dispatch(distfalse, sys.argv, sys.stdin, sys.stdout, name)