Fix XML responses to not throw errors for unicode characters #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `splunklib/data.py` `load` function to convert text provided into a utf-8 string so that Python XML parser will not throw errors when processing utf-8 encoded responses.
…ncoded only for utf strings, so that Python XML parser will not throw errors when processing utf-8 encoded responses.
splunklib/data.py
Outdated
| } | ||
|
|
||
| # Convert to unicode encoding in only python 2 for xml parser | ||
| if sys.version_info < (3, 0, 0): |
Contributor
There was a problem hiding this comment.
we can use and and combine these into a single if
shakeelmohamed
approved these changes
Jun 7, 2018
| if sys.version_info < (3, 0, 0): | ||
| if isinstance(text, unicode): | ||
| text = text.encode('utf-8') | ||
| if(sys.version_info < (3, 0, 0) and isinstance(text, unicode)): |
Contributor
There was a problem hiding this comment.
nit: outer parens aren't necessary but LGTM
zenmoto
approved these changes
Jun 7, 2018
skylasam
deleted the
bug/DVPL-7312-exceptions-raised-for-unicode-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
splunklib/data.pyloadfunction to convert text provided into a utf-8 string so that Python XML parser will not throw errors when processing utf-8 encoded responses.