Update searchcommands app example #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakeelmohamed
suggested changes
Jan 29, 2019
| @@ -0,0 +1 @@ | |||
| /Users/xcheng/repo/github/splunk-sdk-python/splunklib No newline at end of file | |||
Contributor
There was a problem hiding this comment.
git ignore this file?
.vscode/launch.json
Outdated
| @@ -0,0 +1,67 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
git ignore this .vscode dir?
dan1
reviewed
Jan 29, 2019
| process = Popen(recording.get_args(command), stdin=ifile, stderr=PIPE, stdout=PIPE) | ||
| env = os.environ.copy() | ||
| env['PYTHONPATH'] = ":".join(sys.path) | ||
| process = Popen(recording.get_args(command), stdin=ifile, stderr=PIPE, stdout=PIPE, env=env) |
Contributor
There was a problem hiding this comment.
Regarding
env['PYTHONPATH'] = ":".join(sys.path)
I think you want os.pathsep here so that it's ":" for unix and ";" for Windows.
https://docs.python.org/2/library/os.html#os.pathsep
dan1
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchcommands_app example now packages splunklib under lib folder instead of bin folder based on best practice