Remove version check on ssl verify toggle #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mew1033 please rebase to develop, the change looks fine otherwise |
mew1033
force-pushed
the
fix-verify-toggle
branch
from
f1502a6 to
529234c
Compare
Contributor
Author
|
@shakeelmohamed Done. |
shakeelmohamed
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit broke things: ab1d66c#diff-9510d778d209375b033cdfc42fa0cc4bL1344-R1348
If you were running python less than 2.7.9, it made it impossible to disable SSL verification.
At this point, I don't see the reason to keep the check for version 2.7.9+. If SSL isn't working, verification can just be disabled.