feat(mcp-annotations): Add configurable exception handling for MCP to… #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol callbacks - Introduce toolCallExceptionClass field to control which exceptions are converted to error results - Exceptions not matching the configured class are now propagated instead of being converted - O)veride the doGetToolCallException() to change the exceptin type converted into error result - Add overloaded constructors to maintain backward compatibility (default: Exception.class) - Modify exception handling logic in sync/async callbacks to check exception type before conversion - Exceptions not matching the configured class are now propagated instead of being converted - Extract common provider logic into new AbstractMcpToolProvider base class - Add ProvidrerUtils with predicates for reactive type checking - Include test coverage for exception handling scenarios This change allows fine-grained control over exception handling behavior in MCP tool methods, enabling developers to distinguish (and define) between expected errors (converted to CallToolResult) and unexpected failures (propagated for higher-level handling). Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ol callbacks
This change allows fine-grained control over exception handling behavior in MCP tool methods, enabling developers to distinguish (and define) between expected errors (converted to CallToolResult) and unexpected failures (propagated for higher-level handling).