Skip to content
This repository was archived by the owner on Mar 2, 2022. It is now read-only.

Conversation

@sinwe
Copy link
Contributor

@sinwe sinwe commented Jul 4, 2019

Time to merge sreactor branch to master

sinwe and others added 24 commits December 3, 2018 20:09
Signed-off-by: Winarto Zhao <winarto@gmail.com>
Signed-off-by: Winarto Zhao <winarto@gmail.com>
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success 
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [x] http://www.apache.org/licenses/ with 1 occurrences migrated to:  
  https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200).
* [x] http://www.apache.org/licenses/LICENSE-2.0 with 1 occurrences migrated to:  
  https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [x] http://mvnrepository.com/artifact/io.projectreactor/reactor-scala-extensions_2.12 with 1 occurrences migrated to:
  https://mvnrepository.com/artifact/io.projectreactor/reactor-scala-extensions_2.12 ([https](https://mvnrepository.com/artifact/io.projectreactor/reactor-scala-extensions_2.12) result 200).
* [x] http://contributor-covenant.org with 1 occurrences migrated to:
  https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301).
* [x] http://contributor-covenant.org/version/1/4 with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/4 ([https](https://contributor-covenant.org/version/1/4) result 301).
* [x] http://contributor-covenant.org/version/1/4/ with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/4/ ([https](https://contributor-covenant.org/version/1/4/) result 301).
Fixed null handling in SMono.justOrEmpty
Signed-off-by: Winarto Zhao <winarto@gmail.com>
Signed-off-by: Winarto Zhao <winarto@gmail.com>
Signed-off-by: Winarto Zhao <winarto@gmail.com>
@codecov-io
Copy link

codecov-io commented Jul 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@73ac5fe). Click here to learn what that means.
The diff coverage is 26.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   48.98%           
=========================================
  Files             ?       17           
  Lines             ?     1186           
  Branches          ?        8           
=========================================
  Hits              ?      581           
  Misses            ?      605           
  Partials          ?        0
Impacted Files Coverage Δ
...reactor/core/scala/publisher/ScalaConverters.scala 0% <0%> (ø)
...ain/scala/reactor/core/scala/publisher/SMono.scala 0% <0%> (ø)
...ain/scala/reactor/core/scala/publisher/SFlux.scala 0% <0%> (ø)
src/main/scala/reactor/core/scala/Scannable.scala 31.25% <100%> (ø)
...reactor/core/scala/publisher/PimpMyPublisher.scala 55.55% <100%> (ø)
...main/scala/reactor/core/scala/publisher/Flux.scala 76.09% <50%> (ø)
...n/scala/reactor/core/scala/publisher/package.scala 88.63% <50%> (ø)
...scala/reactor/core/scala/publisher/SFluxLike.scala 79.31% <79.31%> (ø)
...main/scala/reactor/core/scala/publisher/Mono.scala 83.11% <83.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ac5fe...10ea928. Read the comment docs.

@sinwe sinwe self-assigned this Jul 4, 2019
@sinwe sinwe merged commit cd15709 into master Jul 4, 2019
@sinwe sinwe deleted the sreactor branch July 8, 2020 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

4 participants