Handle conditionals for client properties #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed properties. Use per-client-property for RetryAwareServiceInstanceListSupplier conditionals.
…nt-based properties. Use per-client-property for property-set configurations, avoiding same instance on retry and service instance cookie for sticky session.
ryanjbaxter
approved these changes
Nov 2, 2021
Contributor
ryanjbaxter
left a comment
ryanjbaxter
left a comment
There was a problem hiding this comment.
Could probably use some unit tests of LoadBalancerEnvironmentPropertyUtils to make sure its behaving as expected
Collaborator
Author
Thanks :) I assumed it's sort of a self-tested feature that should be covered by pre-existing tests as we change the implementation without changing expected behaviour, but will add a few tests just for that class. |
…or-client-properties
…or-client-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make properties other than within
@ConfigurationPropertieswork per-client, with the following global properties exclusions:spring.cloud.loadbalancer.enabledspring.cloud.loadbalancer.retry.enabled- if enabled, still possible to disable per-client only with propertiesspring.cloud.loadbalancer.cache.enabled- if enabled, still possible to disable per-client with custom configurationspring.cloud.loadbalancer.stats.micrometer.enabledFixes gh-1031.